beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

Historically we've duplicated `cmake_policy` calls on a per-project basis which 
we needed to support standalone builds. That said, it would be nice if we had 
LLVM vend some CMake modules that encapsulated this stuff better. In general I 
think that cleanup would be ideal to do after we move LLVM to the GitHub 
mono-repo because then we can create a `cmake/modules` folder at the root of 
the mono-repo that has common modules useable by all sub-projects.

As-is, this patch is the right way to go.


Repository:
  rC Clang

https://reviews.llvm.org/D42490



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D42490: [cmake] Set... Chris Bieneman via Phabricator via cfe-commits

Reply via email to