dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

This looks good to me, although as I noted inline I think both the name and the 
comment for VisitForConstructionContext() are confusing. If you can be more 
precise I think it would help future maintainers.

Comment at: lib/Analysis/CFG.cpp:653
+  // triggered by the given trigger.
+  void VisitForConstructionContext(Stmt *Trigger, Stmt *Child);
I find the name of this method very confusing. It sounds like you are visiting 
an AST node called a 'ForConstructionContext', but that is not what this 
function does. It is also not clear from either the name or the comment what 
the method is supposed to do. Can you be more precise?

You can fix this in a follow-up commit if you like.


cfe-commits mailing list

Reply via email to