yaxunl added inline comments.

================
Comment at: lib/Basic/Targets/AMDGPU.h:85
     return TT.getEnvironmentName() == "amdgiz" ||
+           TT.getOS() == llvm::Triple::CUDA ||
            TT.getEnvironmentName() == "amdgizcl";
----------------
t-tye wrote:
> We still want to use the amdhsa OS for amdgpu which currently supports the 
> different environments. So can cuda simply support the same environments? Is 
> the plan is to eliminate the environments and simply always use the default 
> address space for generic so this code is no longer needed?
Currently we already use amdgiz by default. This is no longer needed.


https://reviews.llvm.org/D42800



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to