SjoerdMeijer added a comment.

Thanks for fixing this. Looks very reasonable to me.

Question about the failures: I am now wondering if this means we were and still 
are missing tests?

Nit: for future reviews, I think it is better to split patches up if they are 
commits to 
different repos.


https://reviews.llvm.org/D42993



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to