Author: ericwf Date: Wed Feb 7 15:50:25 2018 New Revision: 324545 URL: http://llvm.org/viewvc/llvm-project?rev=324545&view=rev Log: Fix size and alignment of array<T, 0>.
An array T[1] isn't necessarily the same say when it's a member of a struct. This patch addresses that problem and corrects the tests to deal with it. Modified: libcxx/trunk/include/__config libcxx/trunk/include/array libcxx/trunk/test/std/containers/sequences/array/size_and_alignment.pass.cpp Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__config?rev=324545&r1=324544&r2=324545&view=diff ============================================================================== --- libcxx/trunk/include/__config (original) +++ libcxx/trunk/include/__config Wed Feb 7 15:50:25 2018 @@ -582,6 +582,7 @@ namespace std { #define __alignof__ __alignof #define _LIBCPP_NORETURN __declspec(noreturn) #define _ALIGNAS(x) __declspec(align(x)) +#define _ALIGNAS_TYPE(x) alignas(x) #define _LIBCPP_HAS_NO_VARIADICS #define _LIBCPP_BEGIN_NAMESPACE_STD namespace std { Modified: libcxx/trunk/include/array URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/array?rev=324545&r1=324544&r2=324545&view=diff ============================================================================== --- libcxx/trunk/include/array (original) +++ libcxx/trunk/include/array Wed Feb 7 15:50:25 2018 @@ -244,10 +244,11 @@ struct _LIBCPP_TEMPLATE_VIS array<_Tp, 0 typedef std::reverse_iterator<iterator> reverse_iterator; typedef std::reverse_iterator<const_iterator> const_reverse_iterator; - typedef typename conditional<is_const<_Tp>::value, const char, char>::type _CharType; - _ALIGNAS(alignment_of<_Tp[1]>::value) _CharType __elems_[sizeof(_Tp[1])]; + + struct _ArrayInStructT { _Tp __data_[1]; }; + _ALIGNAS_TYPE(_ArrayInStructT) _CharType __elems_[sizeof(_ArrayInStructT)]; // No explicit construct/copy/destroy for aggregate type _LIBCPP_INLINE_VISIBILITY void fill(const value_type&) { Modified: libcxx/trunk/test/std/containers/sequences/array/size_and_alignment.pass.cpp URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/containers/sequences/array/size_and_alignment.pass.cpp?rev=324545&r1=324544&r2=324545&view=diff ============================================================================== --- libcxx/trunk/test/std/containers/sequences/array/size_and_alignment.pass.cpp (original) +++ libcxx/trunk/test/std/containers/sequences/array/size_and_alignment.pass.cpp Wed Feb 7 15:50:25 2018 @@ -21,12 +21,26 @@ #include "test_macros.h" + +template <class T, size_t Size> +struct MyArray { + T elems[Size]; +}; + template <class T, size_t Size> void test() { typedef T CArrayT[Size == 0 ? 1 : Size]; typedef std::array<T, Size> ArrayT; - static_assert(sizeof(CArrayT) == sizeof(ArrayT), ""); - static_assert(TEST_ALIGNOF(CArrayT) == TEST_ALIGNOF(ArrayT), ""); + typedef MyArray<T, Size == 0 ? 1 : Size> MyArrayT; + static_assert(sizeof(ArrayT) == sizeof(CArrayT), ""); + static_assert(sizeof(ArrayT) == sizeof(MyArrayT), ""); + static_assert(TEST_ALIGNOF(ArrayT) == TEST_ALIGNOF(MyArrayT), ""); +#if defined(_LIBCPP_VERSION) + ArrayT a; + ((void)a); + static_assert(sizeof(ArrayT) == sizeof(a.__elems_), ""); + static_assert(TEST_ALIGNOF(ArrayT) == __alignof__(a.__elems_), ""); +#endif } template <class T> @@ -44,6 +58,8 @@ struct TEST_ALIGNAS(TEST_ALIGNOF(std::ma char data[1000]; }; +//static_assert(sizeof(void*) == 4, ""); + int main() { test_type<char>(); test_type<int>(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits