ilya-biryukov added a comment.
Thanks for the NITs :-)
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr<CompilerInvocation> CI;
+ // FIXME(ibiryukov): store diagnostics from CommandLine when we start
> Do we still need this block?
I added it to avoid referencing local variables declared there.
I would move this to be a separate function rather than removing the braces
here, but other may have different opinions :-)
WDYT? Does a separate function sound ok?
rCTE Clang Tools Extra
cfe-commits mailing list