ioeric added inline comments.

Comment at: unittests/clangd/SyncAPI.h:8
ilya-biryukov wrote:
> ioeric wrote:
> > Any reason not to put sync APIs in ClangdServer by their async versions, so 
> > that they are easier to find? I might be missing context. But if there is a 
> > good reason, please explain in the file doc.
> That's a good question. I don't think we want anyone using the sync versions 
> of the API. The tests are somewhat special, though, as they'll get really 
> complicated if we move everything to callbacks and we don't want that.
> This probably deserves a comment.
If these are expected to be used by tests only, I'd suggest moving the file to 
the test directory.

  rCTE Clang Tools Extra

cfe-commits mailing list

Reply via email to