george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.

Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:586
+    // they'd be dealt with via an AutomaticObjectDtor instead.
+    const CFGTemporaryDtor &Dtor = Source.castAs<CFGTemporaryDtor>();
+    return PathDiagnosticLocation::createEnd(Dtor.getBindTemporaryExpr(), SM,

Comment at: test/Analysis/inlining/temp-dtors-path-notes.cpp:17
+        // expected-note@-2{{Returning from constructor for 'C'}}
+        // expected-note@-3{{Calling '~C'}}
Should we have "returning from ~C"? At least we do have it for inlined 

cfe-commits mailing list

Reply via email to