tatyana-krasnukha added a comment.
This is what I could note
================
Comment at: clang/lib/Basic/Targets/ARC.h:26
+class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo {
+ static const Builtin::Info BuiltinInfo[];
+
----------------
Looks like unused member, while getTargetBuiltins returns 'None'
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123
+public:
+ ARCABIInfo(CodeGen::CodeGenTypes &CGT) : DefaultABIInfo(CGT) {}
+
----------------
Better use '= default' instead of {}
And you even may use inheriting constructor here
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8165
+ ARCTargetCodeGenInfo(CodeGenTypes &CGT)
+ : TargetCodeGenInfo(new ARCABIInfo(CGT)) {}
+};
----------------
and here
https://reviews.llvm.org/D43089
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
