hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.


Comment at: clangd/ClangdUnit.cpp:197
-    log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
-                      Location, Message));
ilya-biryukov wrote:
> hokein wrote:
> > I'm not sure, do we care about this particular case (diagnostic outside 
> > main file)? With the new change, we don't know whether the diag is from 
> > main file or outside main file。
> We probably don't.
> We output the location of the diagnostic anyway, so there should always be 
> enough context when looking at the logs.
Ah, make sense.

  rCTE Clang Tools Extra


cfe-commits mailing list

Reply via email to