erichkeane marked 3 inline comments as done.
erichkeane added inline comments.

Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325
+        llvm::AttrBuilder Attrs;
+        if (GetCPUAndFeaturesAttributes(D, Attrs)) {
+          // We know that GetCPUAndFeaturesAttributes will always have the
+          // newest set, since it has the newest possible FunctionDecl, so the
+          // new ones should replace the old.
+          F->removeFnAttr("target-cpu");
+          F->removeFnAttr("target-features");
echristo wrote:
> This feels awkward here. On a quick glance I'm not sure why we need this if 
> we're adding above... is it possible to delay in such a way that we're not 
> trying to add twice?
I hadn't seen any.  The other call happens only on a declaration, this happens 
only on definition.  There doesn't really seem to be a way to tell if something 
is GOING to be defined later, since we often emit the declaration immediately.

  rC Clang

cfe-commits mailing list

Reply via email to