tbourvon added inline comments.
Comment at: clang-tidy/utils/Matchers.h:16
> This will require linking in the clangAnalysis library as well; are we sure
> we want to take on this dependency here for all matchers?
Do you have a specific solution in mind? We could make the matcher local to the
check it is being used in (see D37014), but I think it could prove useful for
Comment at: clang-tidy/utils/Matchers.h:58-60
+ // We get the first parent, making sure that we're not in a case statement
+ // not in a compound statement directly inside a switch, because this causes
+ // the buildCFG call to crash.
> Why does it cause the crash? Should that crash not be fixed instead of
> applying this workaround?
I'm not entirely sure if this is expected behavior or not. In terms of AST,
`switch` statements are a bit special in terms of how they are represented
(each case contains all the subsequent cases as its children IIRC).
There probably is a way to make the CFG work in these cases, but I honestly
don't have the time to look into that and attempt a fix. Couldn't this be good
enough for now, maybe with a FIXME?
rCTE Clang Tools Extra
cfe-commits mailing list