yaxunl added inline comments.

Comment at: test/CodeGenOpenCL/address-spaces.cl:37
+// SPIR: i32 addrspace(2)* %arg
+// GIZ: i32 addrspace(4)* %arg
 void f__c(__constant int *arg) {}
t-tye wrote:
> Suggest using the same name across all the OpenCL tests as some are using 
> GIZ, some AMD and some AMDGCN. AMDGCN seems the clearer now that only have a 
> single address space mapping? Similar comment for other places GIZ/AMD is 
> being mentioned.
Will have a separate patch to cleanup the tests.

Comment at: test/CodeGenOpenCL/amdgpu-env-amdgiz.cl:4
-// CHECK: target datalayout = 
+// CHECK: target datalayout = 
 void foo(void) {}
t-tye wrote:
> Should this test be renamed to amdgpu-env-amdgcn.cl now there is a single 
> address space mapping (and delete any relating to the old mapping if they 
> exist)?
will rename it when committing.


cfe-commits mailing list

Reply via email to