erichkeane added a comment.

>> OK. My concern is that users need to use __attribute__((used)) or something 
>> more robust if they want SVN identifiers to reliably appear in the output. 
>> Adding this flag just creates a trap that will fail once they turn on >>-O2. 
>> I'd rather not have it in the interface to avoid that user confusion.

Since the idea here is to have a global option for 'always emit these things', 
could a viable solution simply add all of these things to @llvm.used.  This 
wouldn't affect the usefulness of __attribute((used)), but could be implemented 
similarly, right?


https://reviews.llvm.org/D40925



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to