EricWF added a comment.

LGTM except the removal of the test. I think it's probably valuable to keep 
around on platforms that allow it.

What do you think?

Comment at: 
-    ec = GetTestEC();
-    last_write_time(p, Clock::now());
I would really love to keep this test. I think it has the ability to detect 
incorrect integer arithmetic in `last_write_time` when UBSAN is enabled.

Could we maybe add another check like `SupportsAlmostMinTime` where that checks 
`::min() + MicroSec(1)`?

cfe-commits mailing list

Reply via email to