ilya-biryukov updated this revision to Diff 134589. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment.
- Attach completion kind in CodeCompleteFlow::run(). - Move printCompletionKind closer to CompletionContext::Kind. - Added FIXME to remove tracing of filename. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43377 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp =================================================================== --- clangd/CodeComplete.cpp +++ clangd/CodeComplete.cpp @@ -828,12 +828,17 @@ CompletionList Output; semaCodeComplete(std::move(RecorderOwner), Opts.getClangCompleteOpts(), SemaCCInput, [&] { - if (Recorder.CCSema) + if (Recorder.CCSema) { Output = runWithSema(); - else + SPAN_ATTACH( + Tracer, "sema_completion_kind", + printCompletionKind(Recorder.CCContext.getKind())); + } else log("Code complete: no Sema callback, 0 results"); }); + // FIXME: remove "file" from here after TUScheduler starts logging it. + SPAN_ATTACH(Tracer, "file", SemaCCInput.FileName); SPAN_ATTACH(Tracer, "sema_results", NSema); SPAN_ATTACH(Tracer, "index_results", NIndex); SPAN_ATTACH(Tracer, "merged_results", NBoth);
Index: clangd/CodeComplete.cpp =================================================================== --- clangd/CodeComplete.cpp +++ clangd/CodeComplete.cpp @@ -828,12 +828,17 @@ CompletionList Output; semaCodeComplete(std::move(RecorderOwner), Opts.getClangCompleteOpts(), SemaCCInput, [&] { - if (Recorder.CCSema) + if (Recorder.CCSema) { Output = runWithSema(); - else + SPAN_ATTACH( + Tracer, "sema_completion_kind", + printCompletionKind(Recorder.CCContext.getKind())); + } else log("Code complete: no Sema callback, 0 results"); }); + // FIXME: remove "file" from here after TUScheduler starts logging it. + SPAN_ATTACH(Tracer, "file", SemaCCInput.FileName); SPAN_ATTACH(Tracer, "sema_results", NSema); SPAN_ATTACH(Tracer, "index_results", NIndex); SPAN_ATTACH(Tracer, "merged_results", NBoth);
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits