[PATCH] D43411: [clangd] Rename some protocol field to lower case

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle created this revision.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, 
klimek.

Also fixes a GCC compilation error.

Signed-off-by: Marc-Andre Laperle <marc-andre.lape...@ericsson.com>


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43411

Files:
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/XRefs.cpp
  unittests/clangd/XRefsTests.cpp


Index: unittests/clangd/XRefsTests.cpp
===================================================================
--- unittests/clangd/XRefsTests.cpp
+++ unittests/clangd/XRefsTests.cpp
@@ -559,7 +559,7 @@
     auto AST = build(T.code());
     Hover H = getHover(AST, T.point());
 
-    EXPECT_EQ(H.Contents.Value, Test.ExpectedHover) << Test.Input;
+    EXPECT_EQ(H.contents.value, Test.ExpectedHover) << Test.Input;
   }
 }
 
Index: clangd/XRefs.cpp
===================================================================
--- clangd/XRefs.cpp
+++ clangd/XRefs.cpp
@@ -382,9 +382,9 @@
   if (NamedScope) {
     assert(!NamedScope->empty());
 
-    H.Contents.Value += "Declared in ";
-    H.Contents.Value += *NamedScope;
-    H.Contents.Value += "\n\n";
+    H.contents.value += "Declared in ";
+    H.contents.value += *NamedScope;
+    H.contents.value += "\n\n";
   }
 
   // We want to include the template in the Hover.
@@ -401,16 +401,16 @@
 
   OS.flush();
 
-  H.Contents.Value += DeclText;
+  H.contents.value += DeclText;
   return H;
 }
 
 /// Generate a \p Hover object given the macro \p MacroInf.
 static Hover getHoverContents(StringRef MacroName) {
   Hover H;
 
-  H.Contents.Value = "#define ";
-  H.Contents.Value += MacroName;
+  H.contents.value = "#define ";
+  H.contents.value += MacroName;
 
   return H;
 }
Index: clangd/Protocol.h
===================================================================
--- clangd/Protocol.h
+++ clangd/Protocol.h
@@ -486,18 +486,18 @@
 };
 
 struct MarkupContent {
-  MarkupKind Kind = MarkupKind::PlainText;
-  std::string Value;
+  MarkupKind kind = MarkupKind::PlainText;
+  std::string value;
 };
 json::Expr toJSON(const MarkupContent &MC);
 
 struct Hover {
   /// The hover's content
-  MarkupContent Contents;
+  MarkupContent contents;
 
   /// An optional range is a range inside a text document
   /// that is used to visualize a hover, e.g. by changing the background color.
-  llvm::Optional<Range> Range;
+  llvm::Optional<Range> range;
 };
 json::Expr toJSON(const Hover &H);
 
Index: clangd/Protocol.cpp
===================================================================
--- clangd/Protocol.cpp
+++ clangd/Protocol.cpp
@@ -397,20 +397,20 @@
 }
 
 json::Expr toJSON(const MarkupContent &MC) {
-  if (MC.Value.empty())
+  if (MC.value.empty())
     return nullptr;
 
   return json::obj{
-      {"kind", toTextKind(MC.Kind)},
-      {"value", MC.Value},
+      {"kind", toTextKind(MC.kind)},
+      {"value", MC.value},
   };
 }
 
 json::Expr toJSON(const Hover &H) {
-  json::obj Result{{"contents", toJSON(H.Contents)}};
+  json::obj Result{{"contents", toJSON(H.contents)}};
 
-  if (H.Range.hasValue())
-    Result["range"] = toJSON(*H.Range);
+  if (H.range.hasValue())
+    Result["range"] = toJSON(*H.range);
 
   return std::move(Result);
 }

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits