sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
thanks! couple of nits ================ Comment at: clangd/clients/clangd-vscode/README.md:55 + +Everytime you make a change to `clangd-vscode`, you are expected to publish a +new version to the Extension Marketplace. ---------------- Is this true? Might be more accurate to say that changes to `clangd-vscode` are not released until a new version is published to the marketplace. ================ Comment at: clangd/clients/clangd-vscode/README.md:61 +* Make sure install the `vsce` command (`npm install -g vsce`) +* `llvm-vs-code-extensions` account + ---------------- increase the version number in (whatever the filename is), and commit that change? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43455 _______________________________________________ cfe-commits mailing list firstname.lastname@example.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits