rsmith added inline comments.

Comment at: lib/Serialization/ASTReader.cpp:2554-2556
+      Module *M = PP.getHeaderSearchInfo().lookupModule(
+          F.ModuleName,
+          /*AllowSearch*/ true, /*SearchTopLevelOnly*/ true);
This is only trying to catch the case where we've already loaded a module map 
for the module and the two conflict. We should just set `AllowSearch` to 
`false` here. If we want to also perform validation on the case where we load 
the module map after importing another definition, that should be handled 
if/when we load the module map.

cfe-commits mailing list

Reply via email to