[PATCH] D43696: Reduce hash collisions for reference and pointer types

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

Looks reasonable, can you add a testcase that shows the ODR checker now 
distinguishes pointers/references to distinct types?



================
Comment at: lib/AST/ODRHash.cpp:581
+  void VisitType(const Type *T) {
+    ID.AddInteger(T->getTypeClass());
+  }
----------------
This looks redundant, the above `Visit(const Type*)` function seems to already 
do this.


Repository:
  rC Clang

https://reviews.llvm.org/D43696



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits