lebedev.ri added inline comments.

================
Comment at: clang-doc/BitcodeWriter.h:37
+  static constexpr unsigned SubblockIDSize = 4U;
+  static constexpr unsigned BoolSize = 1U;
+  static constexpr unsigned IntSize = 16U;
----------------
Hmm, you build with asserts enabled, right?
I tried testing this, and three tests fail with
```
clang-doc: /build/llvm/include/llvm/Bitcode/BitstreamWriter.h:122: void 
llvm::BitstreamWriter::Emit(uint32_t, unsigned int): Assertion `(Val & ~(~0U >> 
(32-NumBits))) == 0 && "High bits set!"' failed.
```
```
Failing Tests (3):
    Clang Tools :: clang-doc/mapper-class-in-function.cpp
    Clang Tools :: clang-doc/mapper-function.cpp
    Clang Tools :: clang-doc/mapper-method.cpp

  Expected Passes    : 6
  Unexpected Failures: 3
```
At least one failure is because of `BoolSize`, so i'd suspect the assertion 
itself is wrong...


https://reviews.llvm.org/D41102



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to