2018. márc. 1. 14:58 ezt írta ("Ilya Biryukov" <ibiryu...@google.com>):I replied to a commit in the wrong thread (https://reviews.llvm.org/rL326323), sorry. Here are the important bits: This change introduced the following cyclic dependency in the build system: StaticAnalyzerCore -> CrossTU -> Frontend -> StaticAnalyzerCore. I do not see the Frontend -> StaticAnalyzerCore dependency upstream. See: https://github.com/llvm-mirror/clang/blob/master/lib/Frontend/CMakeLists.txt Do I miss something here? Thanks in advance, Gábor I'm sorry, but I had to revert the commit in r326432. Cyclic dependency broke our internal integrate (we use a different buildsystem, which breaks on cyclic deps) and it's really messy to workaround it since CrossTU depends on both Index and Frontend. Moving the code that uses CrossTU from StaticAnalyzerCore to StaticAnalyzerFrontend should probably fix it, but I don't have enough context to come up with a fix. On Thu, Mar 1, 2018 at 2:01 PM Aleksei Sidorin via Phabricator via cfe-commits <cfe-commits@lists.llvm.org> wrote: > a.sidorin reopened this revision. > a.sidorin added a comment. > > The changes were reverted: http://llvm.org/viewvc/llvm- > project?rev=326432&view=rev > Gabor, could you take a look? > > > Repository: > rC Clang > > https://reviews.llvm.org/D30691 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > -- Regards, Ilya Biryukov
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
