aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from two minor nits, this LGTM. Thank you for working on it!

Comment at: test/Sema/attr-ownership.cpp:1
+// RUN: %clang_cc1 %s -verify
Please pass `-fsyntax-only` as well.

Comment at: utils/TableGen/ClangAttrEmitter.cpp:763
+         << "        assert(HasThis == Idx.hasThis() && "
+            "\"HasThis must be consistent\");\n"
+         << "      }\n"
Given how oddly this is wrapped, might as well make this a stream argument 
rather than a string literal concatenation.


cfe-commits mailing list

Reply via email to