ABataev added inline comments.
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:591
+ llvm::sys::path::append(DefaultLibPath, "lib" CLANG_LIBDIR_SUFFIX);
+ LibraryPaths.emplace_back(DriverArgs.MakeArgString(DefaultLibPath));
+
----------------
Maybe just `LibraryPaths.emplace_back(DefaultLibPath);`?
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:598
+ llvm::SplitString(*LibPath, Frags,
+ StringRef(&(llvm::sys::EnvPathSeparator)));
+ for (auto Path : Frags)
----------------
Wow, never do such things! This is a pointer to non-null terminated string.
Instead
```
const char EnvPathSeparatorStr[] = {EnvPathSeparator, '\0'};
```
And use this array as a separator.
Repository:
rC Clang
https://reviews.llvm.org/D43197
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
