thakis marked an inline comment as done. thakis added inline comments.
================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206 + + for (const VBase &V : VBases) { + if (!V.second.hasVtorDisp()) ---------------- rnk wrote: > I think we can avoid the sort altogether if we iterate `RD->vbases()`, which > should already be in layout order, and then do lookup into `VBaseMap`. That's way nicer, thanks. Done. https://reviews.llvm.org/D44223 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits