thakis marked an inline comment as done.
thakis added inline comments.

Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206
+  for (const VBase &V : VBases) {
+    if (!V.second.hasVtorDisp())
rnk wrote:
> I think we can avoid the sort altogether if we iterate `RD->vbases()`, which 
> should already be in layout order, and then do lookup into `VBaseMap`.
That's way nicer, thanks. Done.

cfe-commits mailing list

Reply via email to