Eric, Any chance you could have one more look at this and let me know if the patch is acceptable?
Thanks, Mike On Mon, Mar 5, 2018 at 4:16 PM, Mike Edwards via Phabricator < revi...@reviews.llvm.org> wrote: > sqlbyme updated this revision to Diff 137104. > sqlbyme added a comment. > > I copied what Eric did here: https://github.com/llvm-mirror/libcxx/commit/ > 6878e852d1d26cca0abee3013822311cd894ca3e. I have tested this on our bots > and the fix works fine. > > > https://reviews.llvm.org/D44103 > > Files: > test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp > > > Index: test/std/strings/basic.string/string.cons/iter_alloc_ > deduction.fail.cpp > =================================================================== > --- test/std/strings/basic.string/string.cons/iter_alloc_ > deduction.fail.cpp > +++ test/std/strings/basic.string/string.cons/iter_alloc_ > deduction.fail.cpp > @@ -9,8 +9,7 @@ > > // <string> > // UNSUPPORTED: c++98, c++03, c++11, c++14 > -// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, > clang-3.8, clang-3.9, clang-4.0 > -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0 > +// XFAIL: libcpp-no-deduction-guides > > // template<class InputIterator, > // class Allocator = allocator<typename > iterator_traits<InputIterator>::value_type>> > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits