ilya-biryukov added inline comments.

Comment at: clangd/XRefs.cpp:201
   std::vector<MacroDecl> MacroInfos = DeclMacrosFinder->takeMacroInfos();
+  if (!MacroInfos.empty()) {
+    for (auto Item : MacroInfos) {
I wonder whether we should fix the `DeclrationAndMacrosFinder` to not return 
declarations coming from macro instantiations instead.
There are other clients (e.g. document highlights) that will probably break in 
the same way.

Do you think it would be possible and it would make sense for 
`DeclrationAndMacrosFinder` to only return a macro in this case and not return 
Decls coming from macro expansions?

  rCTE Clang Tools Extra

cfe-commits mailing list

Reply via email to