hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
This also aligns with the behavior of declarations. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44423 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsTests.cpp =================================================================== --- unittests/clangd/XRefsTests.cpp +++ unittests/clangd/XRefsTests.cpp @@ -207,15 +207,15 @@ R"cpp(// Macro #define MACRO 0 - #define [[MACRO 1]] + #define [[MACRO]] 1 int main() { return ^MACRO; } #define MACRO 2 #undef macro )cpp", R"cpp(// Macro class TTT { public: int a; }; - #define [[FF(S) if (int b = S.a) {}]] + #define [[FF]](S) if (int b = S.a) {} void f() { TTT t; F^F(t); Index: clangd/XRefs.cpp =================================================================== --- clangd/XRefs.cpp +++ clangd/XRefs.cpp @@ -219,9 +219,8 @@ } for (auto Item : MacroInfos) { - SourceRange SR(Item.Info->getDefinitionLoc(), - Item.Info->getDefinitionEndLoc()); - auto L = makeLocation(AST, SR); + auto Loc = Item.Info->getDefinitionLoc(); + auto L = makeLocation(AST, SourceRange(Loc, Loc)); if (L) Result.push_back(*L); }
Index: unittests/clangd/XRefsTests.cpp =================================================================== --- unittests/clangd/XRefsTests.cpp +++ unittests/clangd/XRefsTests.cpp @@ -207,15 +207,15 @@ R"cpp(// Macro #define MACRO 0 - #define [[MACRO 1]] + #define [[MACRO]] 1 int main() { return ^MACRO; } #define MACRO 2 #undef macro )cpp", R"cpp(// Macro class TTT { public: int a; }; - #define [[FF(S) if (int b = S.a) {}]] + #define [[FF]](S) if (int b = S.a) {} void f() { TTT t; F^F(t); Index: clangd/XRefs.cpp =================================================================== --- clangd/XRefs.cpp +++ clangd/XRefs.cpp @@ -219,9 +219,8 @@ } for (auto Item : MacroInfos) { - SourceRange SR(Item.Info->getDefinitionLoc(), - Item.Info->getDefinitionEndLoc()); - auto L = makeLocation(AST, SR); + auto Loc = Item.Info->getDefinitionLoc(); + auto L = makeLocation(AST, SourceRange(Loc, Loc)); if (L) Result.push_back(*L); }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits