jkorous-apple created this revision.
jkorous-apple added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, ioeric, ilya-biryukov.
Since I was reading this code I decided I might just as well polish it a
little. It is just preliminary commit for a bug-fix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44575
Files:
clangd/index/Index.h
Index: clangd/index/Index.h
===================================================================
--- clangd/index/Index.h
+++ clangd/index/Index.h
@@ -54,16 +54,18 @@
}
private:
+ static constexpr unsigned HashByteLength = 20;
+
friend llvm::hash_code hash_value(const SymbolID &ID) {
// We already have a good hash, just return the first bytes.
- static_assert(sizeof(size_t) <= 20, "size_t longer than SHA1!");
+ static_assert(sizeof(size_t) <= HashByteLength, "size_t longer than
SHA1!");
return *reinterpret_cast<const size_t *>(ID.HashValue.data());
}
friend llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
const SymbolID &ID);
friend void operator>>(llvm::StringRef Str, SymbolID &ID);
- std::array<uint8_t, 20> HashValue;
+ std::array<uint8_t, HashByteLength> HashValue;
};
// Write SymbolID into the given stream. SymbolID is encoded as a 40-bytes
Index: clangd/index/Index.h
===================================================================
--- clangd/index/Index.h
+++ clangd/index/Index.h
@@ -54,16 +54,18 @@
}
private:
+ static constexpr unsigned HashByteLength = 20;
+
friend llvm::hash_code hash_value(const SymbolID &ID) {
// We already have a good hash, just return the first bytes.
- static_assert(sizeof(size_t) <= 20, "size_t longer than SHA1!");
+ static_assert(sizeof(size_t) <= HashByteLength, "size_t longer than SHA1!");
return *reinterpret_cast<const size_t *>(ID.HashValue.data());
}
friend llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
const SymbolID &ID);
friend void operator>>(llvm::StringRef Str, SymbolID &ID);
- std::array<uint8_t, 20> HashValue;
+ std::array<uint8_t, HashByteLength> HashValue;
};
// Write SymbolID into the given stream. SymbolID is encoded as a 40-bytes
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
