bruno added inline comments.

================
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:3
+// RUN: not %clang_cc1 -std=c++11 -I %S/libc-empty-except-sys -fexceptions 
-fcxx-exceptions -fsyntax-only -verify %s
+
+// expected-no-diagnostics
----------------
Since this is intended to fix a problem you are seeing with modules on, perhaps 
you should create modulemaps and test this with -fmodules? 


================
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:6
+#include "libc-empty-except.h"
+
+void f() {
----------------
In a testcase like this but using the actual real headers, if you do:

#include <xmmintrin.h>
#include <stdlib.h>

does it also compiles fine?


Repository:
  rC Clang

https://reviews.llvm.org/D43871



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D43871: [... Bruno Cardoso Lopes via Phabricator via cfe-commits

Reply via email to