rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Sema/Sema.cpp:855 // instantiations. PCH files do not. if (TUKind != TU_Prefix) { DiagnoseUseOfUnimplementedSelectors(); ---------------- rnk wrote: > rsmith wrote: > > In the TUPrefix case, we'll need to write these instantiations to the PCH > > file. > I think this addresses that. Now that we are at global scope, nobody will > eagerly attempt to instantiate everything on the pending instantiation queue > until end of TU. Subtle, but I agree. Thanks! https://reviews.llvm.org/D44846 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits