baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added inline comments.
================ Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:24-25 + +const TypeVec _throws(const FunctionDecl *Func); +const TypeVec _throws(const Stmt *St, const TypeVec &Caught); +} // namespace ---------------- alexfh wrote: > alexfh wrote: > > Function names should follow llvm conventions > > http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly > If there's no need to pass nullptr to these functions, the arguments can be > const references. I agree in general, but I usually get `Stmt*` and `FunctionDecl*` from query functions, so it is simpler to pass them as they are instead of dereferencing them. The too many asterisks decrease the readability of the code. Furthermore, St may be `nullptr` in the second function. https://reviews.llvm.org/D33537 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
