EricWF added inline comments.
================ Comment at: include/experimental/coroutine:262 +struct noop_coroutine_promise {}; + ---------------- This whole thing should be wrapped in a `__has_builtin(__builtin_coro_noop)` so the header still compiles with older clang versions. ================ Comment at: include/experimental/coroutine:294 + +inline _LIBCPP_ALWAYS_INLINE +noop_coroutine_handle noop_coroutine() _NOEXCEPT { ---------------- This should just be `_LIBCPP_INLINE_VISIBILITY`. We try not to use `_LIBCPP_ALWAYS_INLINE` in new code. ================ Comment at: test/std/experimental/language.support/support.coroutines/coroutine.handle/coroutine.handle.noop/noop_coroutine.pass.cpp:12 +// UNSUPPORTED: c++98, c++03, c++11 + +// <experimental/coroutine> ---------------- This probably needs an `// XFAIL: clang-5, clang-6` https://reviews.llvm.org/D45121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits