tkrupa marked 4 inline comments as done.
tkrupa added inline comments.

================
Comment at: lib/CodeGen/CGBuiltin.cpp:8901
   }
-
+  case X86::BI__builtin_ia32_sqrtsd_round_mask:
+  case X86::BI__builtin_ia32_sqrtss_round_mask: {
----------------
craig.topper wrote:
> What about __builtin_ia32_sqrtsd and __builtin_ia32_sqrtss?
There was a misunderstanding earlier - Uriel and me both took up this task 
simultaneously. We found out during the implementation phase and decided that 
he'd do this part (since it already was in the phabricator) and I'd do 
builtin_ia32_sqrtsd and builtin_ia32_sqrtss in another patch (lowering them 
require handling some dependencies) The other patch is currently going through 
internal review. 


Repository:
  rC Clang

https://reviews.llvm.org/D41168



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to