manojgupta added inline comments.

================
Comment at: include/clang/Driver/Options.td:1286
 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, 
Group<f_Group>,
     Flags<[CC1Option]>, HelpText<"Disallow merging of constants">;
 def fno_modules : Flag <["-"], "fno-modules">, Group<f_Group>,
----------------
rjmccall wrote:
> rsmith wrote:
> > Remove the `Flags<[CC1Option]>` here, since `-cc1` no longer understands 
> > this flag.
> Did you mean to remove the help text here?  It's still a meaningful driver 
> option.
 I agree that it is meaningful and also useful to have the help text around. I 
had removed it since previously  "fmerge-all-constants" didn't have it. 


Repository:
  rC Clang

https://reviews.llvm.org/D45289



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to