spatel added a comment.

> The only question I have is whether its ok to emit the v2i32 intermediate 
> type for the 128-bit version. I wasn't sure of any examples where we use an 
> illegal type in our intrinsic/builtin handling. At least not a narrower type. 
> I know pavg uses a wider type.

I don't know of any precedence at this level, but we created illegal scalar int 
types (i128/i256) as part of memcmp expansion knowing that we'd match and 
combine those specific patterns in the DAG for x86. I figured that as long as 
we take responsibility for handling the illegal types, it's ok to do 
that...nobody has complained so far. :)


Repository:
  rC Clang

https://reviews.llvm.org/D45421



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to