sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/URI.h:69 + /// calculate the include path from the resolved absolute path. + static llvm::Expected<std::string> includePath(const URI &U); + ---------------- hokein wrote: > sammccall wrote: > > i'd avoid the name "include path" because it can be confused with a) the > > set of directories passed to -I and b) the filesystem path to the file to > > be included. > > Suggest includeString or so > Renamed it to `spellingInclude`. nit: I think `includeSpelling` would be clearer, since include is the adjective. Up to you Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
