thakis added a comment.

This landing made our clang trunk bots do an evaluation of this warning :-P It 
fired 8 times, all false positives, and all from unit tests testing that 
operator= works for self-assignment. 
( has the 
exact details) It looks like the same issue exists in LLVM itself too,

Now tests often need warning suppressions for things like this, and this in 
itself doesn't seem horrible. However, this change takes a warning that was 
previously 100% noise-free in practice and makes it pretty noisy – without a 
big benefit in practice. I get that it's beneficial in theory, but that's true 
of many warnings.

Based on how this warning does in practice, I think it might be better for the 
static analyzer, which has a lower bar for false positives.

  rC Clang

cfe-commits mailing list

Reply via email to