sammccall added a comment.

Is this patch still relevant after haojian's string deduplication?

Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:53
+/// Combines occurrences of the same symbols across translation units.
+class SymbolMerger {
Seems reasonably likely we would actually have contention here? merging 
per-thread (combiner) and then globally at the end (reducer) might be the way 
to go (might be significantly faster). But not sure how big the impact is.

  rCTE Clang Tools Extra

cfe-commits mailing list

Reply via email to