aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from some minor nits, LGTM! ================ Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:28 + // Do not count decomposition declarations (C++17's structured bindings). + // Do not count variables declared in macros. + if (StructNesting == 0 && ---------------- Comment is now stale. ================ Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:31 + !(isa<ParmVarDecl>(VD) || isa<DecompositionDecl>(VD))) + Info.Variables++; + return true; ---------------- Do you mind switching these to preincrement (and predecrement, below) since the value is not subsequently used? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
