rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

I'd still prefer if someone with more driver-design expertise weighed in, but 
we might not have any specialists there.

LGTM, although you might consider changing your tests a bit: FileCheck recently 
added support for a -D argument where you can predefine variables in the 
command line.  But that's just a suggestion, not something I'm asking you to do 
as part of review.


cfe-commits mailing list

Reply via email to