efriedma added a comment.

The thing about the bool*-only version is that bool pointers are rare in C++, 
so I'm not sure we're gaining much.  But if we can't do something more general, 
there's still some benefit.

I see your point about false positives for the more general version. I was sort 
of considering an attribute to allow implicit conversions to bool for a 
specific function (like an assertion), and then we could ban implicit 
conversions to bool for parameters to other functions.  But that's probably 
overkill.


https://reviews.llvm.org/D45601



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to