JonasToth added inline comments.
================ Comment at: clang-tidy/utils/ASTUtils.cpp:226 + + // If 'Exp' is bound to a non-const reference, check all declRefExpr to that. + const auto Refs = match( ---------------- What about transitive references and pointers? It seems that only references are checked, but if a pointer is taken through that reference and vice versa, is that tracked correctly? ================ Comment at: clang-tidy/utils/ASTUtils.cpp:233 + conditionalOperator(anyOf( + hasTrueExpression(equalsNode(&Exp)), + hasFalseExpression(equalsNode(&Exp)))))), ---------------- If the `Exp` is an array, that will not match array subscript? Are there other similar cases? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
