klimek added inline comments.

================
Comment at: lib/Format/WhitespaceManager.cpp:438
+
+  AlignTokens(Style,
+              [&](const Change &C) {
----------------
I'm not sure whether we should use AlignTokens here, given that we pass in a 
parameter to basically skip all its interesting logic.

What I'd personally do is try to implement the alignment of macros on their own 
merit from scratch, which should be significantly simpler, and then look for 
whether we can pull out common functions between AlignTokens and that 
implementation to further reduce duplication.


Repository:
  rL LLVM

https://reviews.llvm.org/D28462



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to