chandlerc added a comment. In https://reviews.llvm.org/D45505#1074747, @mstorsjo wrote:
> In https://reviews.llvm.org/D45505#1074744, @chandlerc wrote: > > > Definitely need tests here. > > > Do you have any suggestion on where to create them and what kind? Just a > normal test with a fake directory tree, or some sort of unit test for the gcc > version number matching logic? (And if creating a unit test, how does that > work since this class isn't in the public include directory?) All of this logic is tested with fake directories trees and tests in test/Driver. Should be able to look at other commits in this space to see examples of test? Repository: rC Clang https://reviews.llvm.org/D45505 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
