BillyONeal added a comment.

In https://reviews.llvm.org/D45715#1075665, @mclow.lists wrote:

> - if there are similar tests in the filesystem test suite, and you haven't 
> tripped over them because you spelled your error message the same as we did.


Almost certainly. But we aren't running your filesystem tests yet because they 
are still under experimental. There are probably a lot of POSIX assumptions 
everywhere in there given the root_name parsing business.

In https://reviews.llvm.org/D45715#1075665, @mclow.lists wrote:

> - Should part of this test be moved into test/libcxx


That one's up to you. I don't think the specific message matters to this test; 
clearly the existing asserts for `io_errc::stream` don't care about a specific 
message (which is why they worked on our implementation).


https://reviews.llvm.org/D45715



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D45715: [l... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D4571... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D4571... Marshall Clow via Phabricator via cfe-commits
    • [PATCH] D4571... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D4571... Billy Robert O'Neal III via Phabricator via cfe-commits

Reply via email to