tra added inline comments.
================ Comment at: lib/CodeGen/CGCUDANV.cpp:51-52 llvm::Constant *getLaunchFn() const; + std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const; + std::string addUnderscoredPrefixToName(CodeGenModule &CGM, + StringRef FuncName) const; ---------------- rjmccall wrote: > tra wrote: > > `const CodeGenModule &CGM` > Why doesn't the CGNVCUDARuntime just hold on to a reference to the CGM? > That's what we do with all the other separated singletons (like the > CGCXXABI), and it would let you avoid some of the redundant fields like > Context and TheModule. Actually, CGCUDARuntime already has CGM field, so the CGM argument can be just dropped. https://reviews.llvm.org/D44984 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
