fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Thanks Eli, LGTM!



================
Comment at: lib/Basic/Targets.cpp:641
     Opts->Features.push_back((F.getValue() ? "+" : "-") + F.getKey().str());
+  llvm::sort(Opts->Features.begin(), Opts->Features.end());
 
----------------
Could you add a comment here briefly explaining why we sort here?


Repository:
  rC Clang

https://reviews.llvm.org/D46030



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to