SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land.
I think this looks OK. ================ Comment at: include/clang/Basic/arm_neon.td:1587 +// v8.2-A dot product instructions +let ArchGuard = "defined(__ARM_FEATURE_DOTPROD)" in { + def DOT : SInst<"vdot", "dd88", "iQiUiQUi">; ---------------- Nit: I think it's obvious, but perhaps a comment here, which would be consistent with similar remarks in this file, that this this is for both A32 and A64 (and the one below A64 only)? ================ Comment at: include/clang/Basic/arm_neon_incl.td:256 // c: const pointer type +// 7: vector of 8-bit elements, ignore 'Q' size modifier +// 8: vector of 8-bit elements, same width as default type ---------------- Yes, more modifiers! ;-) ================ Comment at: test/CodeGen/aarch64-neon-dot-product.c:6 + +// Test AArch64 v8.2-A dot product intrinsics + ---------------- Same nit as in of the other patches: not sure if we should spell out Armv8.2-A or if v8.2-A is actually ok. Repository: rL LLVM https://reviews.llvm.org/D46109 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits