yaxunl added a comment. In https://reviews.llvm.org/D46049#1085388, @Anastasia wrote:
> In https://reviews.llvm.org/D46049#1081196, @yaxunl wrote: > > > Can you add a codegen test for 1.2, 2.0? > > > Anything specific you would like me to check? I am not modifying anything in > CodeGen here though. You changed the AST of string literal. We need to check whether the CodeGen for string literal still works. ================ Comment at: lib/AST/ASTContext.cpp:3632 +QualType ASTContext::getStringLiteralBaseType() const { + // OpenCL v1.1 s6.5.3: a string literal is in the constant address space. ---------------- This is not right. The base type of a string literal may not be CharTy, therefore this function needs an input argument which is the original base type and it returns the adjusted base type. (Maybe it should be renamed as adjustStringLiteralBaseType?) Also, you can then use it in StringLiteral::CreateEmpty by passing an empty QualType(). https://reviews.llvm.org/D46049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
